Skip to content

Refactor batching mechanism, solve threading issue #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Apr 16, 2020

Solves with #323 for good, avoiding any shallow copying in the processing thread

@lantiga lantiga requested a review from filipecosta90 April 16, 2020 17:10
@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #325 into master will decrease coverage by 0.21%.
The diff coverage is 83.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   56.96%   56.75%   -0.22%     
==========================================
  Files          27       27              
  Lines        5080     5050      -30     
==========================================
- Hits         2894     2866      -28     
+ Misses       2186     2184       -2     
Impacted Files Coverage Δ
src/err.c 91.66% <0.00%> (ø)
src/redisai.h 0.00% <ø> (ø)
src/script.c 60.18% <33.33%> (ø)
src/backends/tflite.c 70.27% <43.75%> (ø)
src/model.c 68.04% <63.82%> (-1.75%) ⬇️
src/backends/onnxruntime.c 68.43% <66.66%> (ø)
src/backends/tensorflow.c 70.68% <72.22%> (ø)
src/backends/torch.c 85.33% <73.33%> (ø)
src/util/queue.c 83.01% <83.01%> (ø)
src/redisai.c 77.13% <86.45%> (-0.18%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2e4c0...f7e396f. Read the comment docs.

@filipecosta90 filipecosta90 merged commit 26e352b into master Apr 16, 2020
lantiga pushed a commit that referenced this pull request May 6, 2020
 
Merge pull request #325 from RedisAI/batching_threading_fix

Refactor batching mechanism, solve threading issue
@filipecosta90 filipecosta90 deleted the batching_threading_fix branch May 25, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants