Skip to content

Cache model blobs for faster serialization and thread-safety #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Apr 19, 2020

Address #122 and #302
Eventually caching could be deactivated if no RDB saving or AOF rewrite are needed.

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #331 into master will decrease coverage by 0.31%.
The diff coverage is 67.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   56.75%   56.44%   -0.32%     
==========================================
  Files          27       27              
  Lines        5050     5062      +12     
==========================================
- Hits         2866     2857       -9     
- Misses       2184     2205      +21     
Impacted Files Coverage Δ
src/backends/tensorflow.c 68.66% <57.69%> (-2.03%) ⬇️
src/backends/torch.c 84.37% <62.50%> (-0.96%) ⬇️
src/backends/onnxruntime.c 68.01% <100.00%> (-0.43%) ⬇️
src/backends/tflite.c 69.15% <100.00%> (-1.12%) ⬇️
src/libtorch_c/torch_c.cpp 51.15% <0.00%> (-3.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f36dab...614372e. Read the comment docs.

@lantiga lantiga merged commit e768a5c into master Apr 20, 2020
lantiga added a commit that referenced this pull request May 6, 2020
 
Cache model blobs for faster serialization and thread-safety (#331)
@gkorland gkorland deleted the blob_caching branch October 6, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant