Standardized GET (TENSORGET,MODELGET,SCRIPTGET) methods replies (breaking change for clients) #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 56.75% 56.74% -0.01%
==========================================
Files 27 27
Lines 5050 5107 +57
==========================================
+ Hits 2866 2898 +32
- Misses 2184 2209 +25
Continue to review full report at Codecov.
|
|
Genius here forgot to merge origin/master prior to creating patch. Re-pushing soon. |
|
Ok, rebased on master |
hhsecond
approved these changes
Apr 22, 2020
28 tasks
filipecosta90
changed the title
lantiga
added a commit
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #329
Specifically, with this PR, get methods have a uniform signature and behavior
If META is not specified, all methods return a raw binary BLOB, an array VALUES or a raw SOURCE string. This helps, for instance, with dumping a buffer out of a model or a tensor from the CLI.
If only META is specified, all methods return meta data in [key, val, key, val] form. This is a breaking change with respect to the previous behavior (TENSORGET would return [dtype, shape, blob] and not ['dtype', dtype, 'shape', shape, 'blob', blob]), so THIS CHANGE WILL BREAK CLIENTS AND USER CODE.
However, this is our last call to make the API uniform and ready for RESP3.
Other notable changes:
AI.INFO)_MODELLISTcommand has been renamed to_MODELSCAN(to prepare for the upcomingTENSORLISTdata type)Tests and docs have been updated.