Skip to content

1.0 cherry pick #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2020
Merged

1.0 cherry pick #390

merged 2 commits into from
May 28, 2020

Conversation

filipecosta90
Copy link
Collaborator

Cherry picks the following PRs into 1.0

@filipecosta90 filipecosta90 requested a review from K-Jo May 27, 2020 09:25
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #390 into 1.0 will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.0     #390      +/-   ##
==========================================
+ Coverage   72.39%   72.47%   +0.08%     
==========================================
  Files          21       21              
  Lines        4336     4349      +13     
==========================================
+ Hits         3139     3152      +13     
  Misses       1197     1197              
Impacted Files Coverage Δ
src/redisai.c 78.88% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be0f27...71ca962. Read the comment docs.

Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@lantiga
Copy link
Contributor

lantiga commented May 28, 2020

Should we merge this @filipecosta90

@filipecosta90
Copy link
Collaborator Author

Should we merge this @filipecosta90

imho yes. both are important fixes for 1.0 ( lets check @K-Jo )

@filipecosta90 filipecosta90 merged commit 388e7b0 into 1.0 May 28, 2020
@filipecosta90 filipecosta90 deleted the 1.0-cherry-pick branch May 28, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants