Increase refcount for persisted tensors #454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafie FYI there's a CI issue on the gpu machine |
|
@lantiga pip is giving us some hard times with the 20.x versions. I'll resolve it on master. |
lantiga
force-pushed
the
dag-persist-fix
branch
from
46d6594 to
f827553
Compare
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 75.00% 74.89% -0.11%
==========================================
Files 21 21
Lines 4916 4904 -12
==========================================
- Hits 3687 3673 -14
- Misses 1229 1231 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a hotfix for a memory issue with persisted tensor on master.
The issue has been spotted during the analysis of #450.