Script run refactor and llapi #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
+ Coverage 75.84% 76.01% +0.17%
==========================================
Files 25 25
Lines 5406 5508 +102
==========================================
+ Hits 4100 4187 +87
- Misses 1306 1321 +15
Continue to review full report at Codecov.
|
…e runkey in DagOp free function. Closing the model key no longer leeds to a crash.
…disAI/RedisAI into Script_run_refactor_and_LLAPI
DvirDukhan
reviewed
Dec 29, 2020
| int res; | ||
| for (size_t i = 0; i < len; i++) { | ||
| res = Script_RunCtxAddParam(sctx, &sctx->inputs, inputTensors[i]); | ||
| res = _Script_RunCtxAddParam(&sctx->inputs, inputTensors[i]); |
There was a problem hiding this comment.
TBH
The function always returns 1 so maybe it should return void?
Comment on lines
+209
to
+213
| if (!strcasecmp(arg_string, "TIMEOUT")) { | ||
| if (_parseTimeout(argv[++argpos], error, timeout) == REDISMODULE_ERR) | ||
| return REDISMODULE_ERR; | ||
| arg_string = RedisModule_StringPtrLen(argv[++argpos], NULL); | ||
| } |
There was a problem hiding this comment.
Please verify that this is not handled also in the dag parsing
DvirDukhan
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support async LLAPI (part 2/3): Refactor Script run command (parsing, execution as a single DAG op, persist tensors before reply to client). Support async LLAPI, in a similar way to the new model run async LLAPI.