Fix memory leaks #553
Merged
Fix memory leaks #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved dedicated function
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 74.53% 72.57% -1.97%
==========================================
Files 35 35
Lines 5648 5626 -22
==========================================
- Hits 4210 4083 -127
- Misses 1438 1543 +105
Continue to review full report at Codecov.
|
alonre24
reviewed
Jan 13, 2021
src/run_info.c
Outdated
| @@ -163,6 +163,9 @@ void RAI_FreeRunInfo(struct RedisAI_RunInfo *rinfo) { | |||
| return; | |||
| } | |||
| long long ref_count = *rinfo->dagRefCount; | |||
| /* In case of client disconnect, this function will be called for cleanup. | |||
| * It needs to validate the execution has finished. */ | |||
| while(ref_count > 0) {} | |||
src/DAG/dag.c
Outdated
| @@ -588,7 +592,7 @@ static void _ScriptSingleOp_PersistTensors(RedisModuleCtx *ctx, RAI_DagOp *op) { | |||
| const size_t noutputs = RAI_ScriptRunCtxNumOutputs(op->sctx); | |||
| for (size_t outputNumber = 0; outputNumber < noutputs; outputNumber++) { | |||
| RAI_Tensor *tensor = RAI_ScriptRunCtxOutputTensor(op->sctx, outputNumber); | |||
| tensor = tensor ? RAI_TensorGetShallowCopy(tensor) : NULL; | |||
| // tensor = tensor ? RAI_TensorGetShallowCopy(tensor) : NULL; | |||
src/DAG/dag.c
Outdated
| @@ -768,7 +765,7 @@ int RedisAI_DagRun_Reply(RedisModuleCtx *ctx, RedisModuleString **argv, int argc | |||
| } | |||
| } | |||
|
|
|||
| RAI_FreeRunInfo(rinfo); | |||
| // RAI_FreeRunInfo(rinfo); | |||
src/DAG/dag.c
Outdated
| RedisAI_RunInfo *rinfo = RedisModule_GetBlockedClientPrivateData(ctx); | ||
| RAI_FreeRunInfo(rinfo); | ||
| void RunInfo_FreeData(RedisModuleCtx *ctx, void *rinfo) { | ||
| RAI_FreeRunInfo(rinfo); |
There was a problem hiding this comment.
The RunInfo_FreeData is called after the reply function ends?
| rinfo->OnFinish = DAG_ReplyAndUnblock; | ||
| rinfo->client = RedisModule_BlockClient(ctx, RedisAI_DagRun_Reply, NULL, RunInfo_FreeData, 0); | ||
| RedisModule_SetDisconnectCallback(rinfo->client, RedisAI_Disconnected); |
There was a problem hiding this comment.
Why isn't it necessary anymore?
alonre24
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.