Let TENSORGET command return BLOB+META by default #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonre24
force-pushed
the
Support_TENSORGET_command_without_format_arg
branch
from
b47b957 to
d840edc
Compare
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 72.30% 72.31%
=======================================
Files 37 37
Lines 5915 5917 +2
=======================================
+ Hits 4277 4279 +2
Misses 1638 1638
Continue to review full report at Codecov.
|
DvirDukhan
reviewed
Jan 14, 2021
docs/commands.md
Outdated
| @@ -79,7 +79,7 @@ Depending on the specified reply format: | |||
| 1. The tensor's shape as an Array consisting of an item per dimension | |||
| * **BLOB**: the tensor's binary data as a String. If used together with the **META** option, the binary data string will put after the metadata in the array reply. | |||
| * **VALUES**: Array containing the numerical representation of the tensor's data. If used together with the **META** option, the binary data string will put after the metadata in the array reply. | |||
|
|
|||
| * Default: META+BLOB are returned by default, in case that non of the arguments above is specified. | |||
There was a problem hiding this comment.
Suggested change
| * Default: META+BLOB are returned by default, in case that non of the arguments above is specified. | |
| * Default: **META** and **BLOB** are returned by default, in case that non of the arguments above is specified. |
alonre24
force-pushed
the
Support_TENSORGET_command_without_format_arg
branch
from
491ad78 to
0c9c805
Compare
DvirDukhan
approved these changes
Jan 14, 2021
DvirDukhan
pushed a commit
that referenced
this pull request
Feb 3, 2021
…t_format_arg Let TENSORGET command return BLOB+META by default
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.