Skip to content

lint on tags #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021
Merged

lint on tags #571

merged 1 commit into from
Jan 27, 2021

Conversation

DvirDukhan
Copy link
Collaborator

@DvirDukhan DvirDukhan commented Jan 24, 2021

@rafie - from circle ci support:

Hi Dvir,
Thank you for contacting CircleCI Support.
In the build_and_package workflow, there are jobs with filters requiring the lint job. However, no filters are specified for the lint job.
By default, CircleCI will build for all branches, but won't build for any tag.
To have a build triggered when you push a tag you'll need to add the filters to the lint job too.
Let me know if this helps.
Yann - Support Engineer - CircleCI

@DvirDukhan DvirDukhan requested a review from rafie January 24, 2021 05:28
@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #571 (2799032) into master (cc0ff36) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   74.11%   74.14%   +0.03%     
==========================================
  Files          39       39              
  Lines        6081     6081              
==========================================
+ Hits         4507     4509       +2     
+ Misses       1574     1572       -2     
Impacted Files Coverage Δ
src/backends/tensorflow.c 69.38% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0ff36...2799032. Read the comment docs.

@DvirDukhan DvirDukhan merged commit 8a3a3b2 into master Jan 27, 2021
@DvirDukhan DvirDukhan deleted the lint_on_tags branch January 27, 2021 11:57
DvirDukhan added a commit that referenced this pull request Jan 27, 2021
DvirDukhan added a commit that referenced this pull request Jan 27, 2021
Merge pull request #571 from RedisAI/lint_on_tags
@chayim chayim mentioned this pull request Jul 22, 2021
@chayim chayim mentioned this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants