Skip to content

Refactor RAI_getModel/ScriptFromKeyspace #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

alonre24
Copy link
Collaborator

No need to sent RM_Key to these functions. Update the signatures in redisai.h.

@alonre24 alonre24 requested a review from DvirDukhan January 25, 2021 18:56
@alonre24 alonre24 self-assigned this Jan 25, 2021
@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #573 (620a273) into master (7c82c60) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   74.32%   74.27%   -0.05%     
==========================================
  Files          39       39              
  Lines        6083     6083              
==========================================
- Hits         4521     4518       -3     
- Misses       1562     1565       +3     
Impacted Files Coverage Δ
src/redisai.h 0.00% <ø> (ø)
src/DAG/dag_builder.c 100.00% <100.00%> (ø)
src/command_parser.c 83.33% <100.00%> (ø)
src/model.c 77.14% <100.00%> (ø)
src/redisai.c 84.12% <100.00%> (ø)
src/script.c 82.50% <100.00%> (ø)
src/background_workers.c 80.55% <0.00%> (-1.39%) ⬇️
src/DAG/dag.c 82.32% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c82c60...620a273. Read the comment docs.

@alonre24 alonre24 merged commit 812444a into master Feb 2, 2021
@alonre24 alonre24 deleted the Refactor_get_model/script_from_keyspace branch February 2, 2021 07:52
DvirDukhan pushed a commit that referenced this pull request Feb 3, 2021
…eyspace

Refactor RAI_getModel/ScriptFromKeyspace
@chayim chayim mentioned this pull request Jul 22, 2021
@chayim chayim mentioned this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants