CircleCI: dockerhub builds #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvirDukhan
reviewed
Jan 30, 2021
There was a problem hiding this comment.
thanks @rafie !
- edge is only on master
- where is the logic between tagging a
1.0.xto1.2.xwith respect to thelatesttag?
.circleci/config.yml
Outdated
| name: dockerhub-edge | ||
| build_args: EDGE=1 | ||
| <<: *after-build-and-test | ||
| <<: *on-any-branch |
There was a problem hiding this comment.
Suggested change
| <<: *on-any-branch | |
| <<: *on-master |
There was a problem hiding this comment.
(1) this is for testing the PR. will change to "on-master" once it is working.
(2) true. will add support for LATEST_BRANCH=1.2
.circleci/config.yml
Outdated
| - run: | ||
| name: Build for platform | ||
| command: | | ||
| #@@ docker login -u redisai -p $DOCKER_REDISAI_PWD |
.circleci/config.yml
Outdated
Comment on lines
126
to
127
| #@@ make build publish $(./version-params) CPU=1 OSNICK=bionic X64=1 REPO=redisai VERBOSE=1 <<parameters.build_args>> | ||
| #@@ make build publish $(./version-params) GPU=1 OSNICK=bionic X64=1 REPO=redisai VERBOSE=1 <<parameters.build_args>> |
There was a problem hiding this comment.
Don't yet have password for dockerhub/redisai so publish will fail.
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
=======================================
Coverage 74.34% 74.34%
=======================================
Files 39 39
Lines 6062 6062
=======================================
Hits 4507 4507
Misses 1555 1555 Continue to review full report at Codecov.
|
DvirDukhan
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.