join threads on tests #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonre24
reviewed
Feb 3, 2021
tests/flow/tests_dag.py
Outdated
| @@ -771,6 +771,7 @@ def run(): | |||
| # assert that result tensor exists | |||
| ret = con.execute_command("EXISTS {}".format(result_tensor_keyname)) | |||
| env.assertEqual(ret, 1) | |||
| t.join() | |||
There was a problem hiding this comment.
Don't you want to join even before(line 763)? Is there a way to verify that batching actually occurred?
tests/flow/tests_onnx.py
Outdated
| @@ -229,6 +229,7 @@ def run(): | |||
| argmax = max(range(len(values)), key=lambda i: values[i]) | |||
|
|
|||
| env.assertEqual(argmax, 1) | |||
| t.join() | |||
| @@ -284,6 +284,7 @@ def run(): | |||
| exception = e | |||
| env.assertEqual(type(exception), redis.exceptions.ResponseError) | |||
| env.assertEqual("Model did not generate the expected batch size", exception.__str__()) | |||
| t.join() | |||
There was a problem hiding this comment.
I would add "env.assertTrue(False)" after lines 274 and 282, otherwise the test doesn't guarantee that those exceptions were raised...
There was a problem hiding this comment.
ret = con.execute_command('AI.MODELRUN', 'm{1}', 'INPUTS', 'd{1}', 'e{1}', 'OUTPUTS', 'f1{1}', 'f2{1}')
env.assertEqual(ret, b'OK')as a single call might succeed, depends on the threads timing
lantiga
previously approved these changes
Feb 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 74.33% 74.33%
=======================================
Files 39 39
Lines 6062 6062
=======================================
Hits 4506 4506
Misses 1556 1556 Continue to review full report at Codecov.
|
alonre24
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.