lite & rce #603
Merged
lite & rce #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
- Coverage 78.28% 78.25% -0.04%
==========================================
Files 41 41
Lines 6535 6535
==========================================
- Hits 5116 5114 -2
- Misses 1419 1421 +2
Continue to review full report at Codecov.
|
rafie
reviewed
Feb 21, 2021
opt/pack.sh
Outdated
| if [[ -z $VARIANT ]]; then | ||
| local rampfile=ramp.yml | ||
| else | ||
| local rampfile=ramp$VARIANT.yml |
There was a problem hiding this comment.
local rampfile=ramp-${VARIANT}.yml
rafie
reviewed
Mar 11, 2021
opt/Makefile
Outdated
| @@ -219,9 +219,13 @@ pack: $(INSTALLED_TARGET) | |||
| $(SHOW)find $(INSTALL_DIR) -name "*.so" -exec chmod +x {} \; | |||
| $(SHOW)mkdir -p $(ROOT)/bin/artifacts | |||
| ifneq ($(PACK_DEPS),0) | |||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 DEPS=1 ./pack.sh | |||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=0 DEPS=1 ./pack.sh | |||
There was a problem hiding this comment.
why RAMP=0 here?
Also, we can avoid the large ifneq ($(PACK_DEPS),0) and just arrange DEPS=$(PACK_DEPS) with the following:
ifneq ($(PACK_DEPS),0)
override PACK_DEPS:=1
endif
rafie
reviewed
Mar 11, 2021
opt/pack.sh
Outdated
| if [[ -z $VARIANT ]]; then | ||
| local rampfile=ramp.yml | ||
| else | ||
| local rampfile=ramp${VARIANT}.yml |
There was a problem hiding this comment.
local rampfile=ramp-${VARIANT}.yml
(added hyphen)
rafie
reviewed
Mar 11, 2021
opt/Makefile
Outdated
Comment on lines
218
to
228
| pack: $(INSTALLED_TARGET) | ||
| $(SHOW)find $(INSTALL_DIR) -name "*.so" -exec chmod +x {} \; | ||
| $(SHOW)mkdir -p $(ROOT)/bin/artifacts | ||
|
|
||
| ifneq ($(PACK_DEPS),0) | ||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 DEPS=1 ./pack.sh | ||
| else | ||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 DEPS=0 ./pack.sh | ||
| override PACK_DEPS:=1 | ||
| endif | ||
| DEPS=$(PACK_DEPS) | ||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 ./pack.sh | ||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 VARIANT=lite ./pack.sh | ||
| $(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) RAMP=1 VARIANT=rce ./pack.sh |
There was a problem hiding this comment.
ifneq ($(PACK_DEPS),0)
override PACK_DEPS:=1
endif
pack: $(INSTALLED_TARGET)
$(SHOW)find $(INSTALL_DIR) -name "*.so" -exec chmod +x {} \;
$(SHOW)mkdir -p $(ROOT)/bin/artifacts
$(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) DEPS=$(PACK_DEPS) ./pack.sh
$(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) DEPS=$(PACK_DEPS) VARIANT=lite ./pack.sh
$(SHOW)DEVICE=$(DEVICE) BINDIR=$(ROOT)/bin/artifacts INSTALL_DIR=$(INSTALL_DIR) BRANCH=$(BRANCH) DEPS=$(PACK_DEPS) VARIANT=rce ./pack.sh
rafie
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a new variant for Redis AI - Lite
This variant will not broadcast models/scripts in the enterprise cluster and will allow:
resharding
Rof
Replica of
This PR also introduce the RCE variant which is based on the lite, with only ONNX backend