Skip to content

Folder structure refactor #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Folder structure refactor #629

merged 3 commits into from
Mar 15, 2021

Conversation

DvirDukhan
Copy link
Collaborator

@DvirDukhan DvirDukhan commented Mar 9, 2021

this PR introduces:

  1. reorganization of the folder structure into a more logical order.
  2. cosmetics - better include statement readability - order and syntax
  3. replaced include guard with pragma once
  4. removed unused files

The purpose of this PR is to be a building block for enabling generic DAG ops, and as such enable DAG plugin API, for different purpose extensions (e.g. native data types support. As such, we probably like to merge this to 1.2 in the purpose of having a smaller code delta compared to master or 1.4

@DvirDukhan DvirDukhan requested review from lantiga and alonre24 March 9, 2021 16:03
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #629 (7c2c2f0) into master (d6d98ef) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files          41       41           
  Lines        6535     6535           
=======================================
  Hits         5114     5114           
  Misses       1421     1421           
Impacted Files Coverage Δ
src/backends/backends.c 62.89% <ø> (ø)
src/backends/libtflite_c/tflite_c.cpp 58.17% <ø> (ø)
src/backends/libtorch_c/torch_c.cpp 57.89% <ø> (ø)
...ckends/libtorch_c/torch_extensions/torch_redis.cpp 84.44% <ø> (ø)
...backends/libtorch_c/torch_extensions/torch_redis.h 88.88% <ø> (ø)
src/backends/onnxruntime.c 73.10% <ø> (ø)
src/backends/tensorflow.c 70.50% <ø> (ø)
src/backends/tflite.c 64.05% <ø> (ø)
src/backends/torch.c 80.25% <ø> (ø)
src/config/config.c 55.55% <ø> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d98ef...7c2c2f0. Read the comment docs.

lantiga
lantiga previously approved these changes Mar 9, 2021
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new structure looks good to me, it makes it easier to navigate the code.

alonre24
alonre24 previously approved these changes Mar 10, 2021
Copy link
Collaborator

@alonre24 alonre24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DvirDukhan DvirDukhan dismissed stale reviews from alonre24 and lantiga via b73c86e March 11, 2021 21:40
@DvirDukhan DvirDukhan force-pushed the folder_structure_refactor branch 2 times, most recently from b73c86e to 5c9ed95 Compare March 13, 2021 22:00
@DvirDukhan DvirDukhan force-pushed the folder_structure_refactor branch from 5c9ed95 to 7c2c2f0 Compare March 15, 2021 14:05
@DvirDukhan DvirDukhan merged commit 353c7c2 into master Mar 15, 2021
@DvirDukhan DvirDukhan deleted the folder_structure_refactor branch March 15, 2021 16:17
alonre24 pushed a commit that referenced this pull request Mar 16, 2021
@chayim chayim mentioned this pull request Jul 22, 2021
@chayim chayim mentioned this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants