-
Notifications
You must be signed in to change notification settings - Fork 106
Folder structure refactor #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 41 41
Lines 6535 6535
=======================================
Hits 5114 5114
Misses 1421 1421
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new structure looks good to me, it makes it easier to navigate the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
b73c86e
to
5c9ed95
Compare
5c9ed95
to
7c2c2f0
Compare
this PR introduces:
include
statement readability - order and syntaxinclude guard
withpragma once
The purpose of this PR is to be a building block for enabling generic DAG ops, and as such enable DAG plugin API, for different purpose extensions (e.g. native data types support. As such, we probably like to merge this to 1.2 in the purpose of having a smaller code delta compared to
master
or 1.4