fix invalid access after freeing next_item
#636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DvirDukhan confirmed the issue is one 👍 |
filipecosta90
approved these changes
Mar 12, 2021
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
- Coverage 76.74% 76.73% -0.02%
==========================================
Files 41 41
Lines 6519 6520 +1
==========================================
Hits 5003 5003
- Misses 1516 1517 +1
Continue to review full report at Codecov.
|
alonre24
pushed a commit
that referenced
this pull request
Mar 16, 2021
fix invalid access after freeing `next_item`
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes invalid access to a queueItem after it is being removed from the queue, which sets its
prevandnextas NULLcloses #635