Skip to content

Fix leak in running onnx with batching #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

alonre24
Copy link
Collaborator

Call ReleaseTensorTypeAndShape after running onnx model with batching.
Waiting for the fix in minbatchsize logic before merge (currently batching is not always testes)

@alonre24 alonre24 requested a review from DvirDukhan March 14, 2021 11:24
@alonre24 alonre24 self-assigned this Mar 14, 2021
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #639 (e74cedb) into master (dfaed79) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   76.74%   76.73%   -0.02%     
==========================================
  Files          41       41              
  Lines        6520     6521       +1     
==========================================
  Hits         5004     5004              
- Misses       1516     1517       +1     
Impacted Files Coverage Δ
src/backends/onnxruntime.c 67.22% <0.00%> (-0.19%) ⬇️
src/background_workers.c 80.00% <0.00%> (-1.38%) ⬇️
src/model.c 78.28% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfaed79...e74cedb. Read the comment docs.

@alonre24 alonre24 merged commit b39b542 into master Mar 14, 2021
@alonre24 alonre24 deleted the fix_leak_in_running_onnx_with_batching branch March 14, 2021 16:31
alonre24 added a commit that referenced this pull request Mar 16, 2021
…tching

Fix leak in running onnx with batching
@chayim chayim mentioned this pull request Jul 22, 2021
@chayim chayim mentioned this pull request Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants