removed aof tests #764
Merged
removed aof tests #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafie
previously approved these changes
May 30, 2021
Codecov Report
@@ Coverage Diff @@
## master #764 +/- ##
=======================================
Coverage 79.15% 79.15%
=======================================
Files 49 49
Lines 7651 7651
=======================================
Hits 6056 6056
Misses 1595 1595 Continue to review full report at Codecov.
|
chayim
reviewed
May 31, 2021
.circleci/config.yml
Outdated
| @@ -249,7 +249,7 @@ jobs: | |||
| parameters: | |||
| test_args: | |||
| type: string | |||
| default: "CLUSTER=0 AOF=0" | |||
| default: "CLUSTER=0" | |||
There was a problem hiding this comment.
If we're disabling the valgrind-aof job, we should change it's name in circleci to something more appropriate.
chayim
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as #754 introduced dedicated
aofrewrite tests in the test files, the flag forAOFis now redundant and can be removed