Skip to content

circleci changes to meet the MOD-1227 goals with how ci runs #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2021

Conversation

chayim
Copy link
Contributor

@chayim chayim commented May 31, 2021

  1. valgrind-general will now run on external PRs, but not internal unless we add the ci-test label.
  2. gpu builds will now run on external PRs, but not internal unless we add the ci-test label.
  3. Runs on integ branches (master and versioned) continue to run gpu builds as before

This involves moving the executing steps from the workflows to the commands section, then reusing them. As such the workflow is duplicated (with rule changes and a new name), but the commands moved.

@chayim chayim requested a review from DvirDukhan May 31, 2021 08:21
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #766 (3c52a56) into master (ffbf441) will decrease coverage by 0.20%.
The diff coverage is 65.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
- Coverage   79.38%   79.17%   -0.21%     
==========================================
  Files          48       49       +1     
  Lines        7476     7651     +175     
==========================================
+ Hits         5935     6058     +123     
- Misses       1541     1593      +52     
Impacted Files Coverage Δ
src/serialization/AOF/rai_aof_rewrite.c 0.00% <0.00%> (ø)
.../serialization/RDB/decoder/previous/v1/decode_v1.c 64.63% <ø> (ø)
...c/serialization/RDB/decoder/current/v2/decode_v2.c 67.87% <67.87%> (ø)
src/redisai.c 85.46% <100.00%> (+0.03%) ⬆️
src/serialization/RDB/decoder/decode_previous.c 75.00% <100.00%> (+8.33%) ⬆️
src/serialization/RDB/decoder/rai_rdb_decoder.c 100.00% <100.00%> (ø)
src/serialization/RDB/encoder/rai_rdb_encode.c 100.00% <100.00%> (ø)
src/serialization/RDB/encoder/v2/encode_v2.c 89.28% <100.00%> (ø)
src/execution/execution_contexts/modelRun_ctx.c 80.55% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5918030...3c52a56. Read the comment docs.

@chayim
Copy link
Contributor Author

chayim commented May 31, 2021

@DvirDukhan An interesting byproduct of this is that I (clearly) can't name the job, with the same name as during the non-PR run. This means that while we have GitHub rules requiring a passing gate for ci/circleci:build-and-test-gpu, in the forked context there's ci/circleci:build-and-test-gpu-for-forked-prs (etc).

@chayim chayim linked an issue May 31, 2021 that may be closed by this pull request
@chayim chayim merged commit 914c3d5 into master May 31, 2021
@chayim chayim deleted the ck-forkedpr-fix branch May 31, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forked PRs fail to trigger CircleCI Valgrind + GPU actions
2 participants