adding lite to the release automation #773
Conversation
Added to the nightly automation area of CircleCI, in case it gets used in the future
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
==========================================
+ Coverage 79.15% 79.17% +0.02%
==========================================
Files 49 49
Lines 7651 7651
==========================================
+ Hits 6056 6058 +2
+ Misses 1595 1593 -2
Continue to review full report at Codecov.
|
Any AI variant can now run against a specific version of redis, or versions, as defined in its own file
tests/qa/RS_VERSIONS-lite
Outdated
| @@ -0,0 +1,2 @@ | |||
| 6.0.12-58 | |||
| 100.0.0-2400 | |||
There was a problem hiding this comment.
This should be 100.0.0-2440 isn't it? @tomerhekredis ?
There was a problem hiding this comment.
On non-lite @tomerhekredis said we wanted 100.0.0-2400 on on RS_VERSIONS- the 6.0x thing. It's worth noting we can now basically do anything here by adding variants and files. @tomerhekredis ?
There was a problem hiding this comment.
yes, it should be 2440 in all RS_VERSIONS files
tests/qa/RS_VERSIONS
Outdated
| @@ -1,2 +1 @@ | |||
| 6.0.12-58 | |||
| 100.0.0-2400 | |||
There was a problem hiding this comment.
This should be 100.0.0-2440 isn't it? @tomerhekredis ?
| @@ -89,10 +90,12 @@ run_test() { | |||
| } | |||
|
|
|||
| rc=0 | |||
| # By default we use RS_VERSIONS, but with variants they may need to specify their own redis verisons, hence this file | |||
| VERSIONFILE=${HERE}/RS_VERSIONS${VARIANT} | |||
There was a problem hiding this comment.
We send VARIANT=lite from circleci.yaml but the file name is RS_VERSIONS-lite (with a dash) - is that a problem?
There was a problem hiding this comment.
CircleCI passes in VARIANT=-lite, which we use to build the file. This was validated with @tomerhekredis
Co-authored-by: tomerhekredis <[email protected]>
Also added in to the nightly automation area of CircleCI, in case it gets used in the future