Support bool type for tensors #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t overflows than the tensor type in TENSORSET.
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 79.22% 78.92% -0.30%
==========================================
Files 50 50
Lines 7662 7721 +59
==========================================
+ Hits 6070 6094 +24
- Misses 1592 1627 +35
Continue to review full report at Codecov.
|
DvirDukhan
suggested changes
Jun 1, 2021
…for representation.
…disAI/RedisAI into Support_BOOL_type_for_tensors
DvirDukhan
reviewed
Jun 2, 2021
… code accordingly)
DvirDukhan
suggested changes
Jun 3, 2021
| break; | ||
| case RAI_DEVICE_GPU: | ||
| dl_device = kDLGPU; | ||
| dl_device = kDLCUDA; |
There was a problem hiding this comment.
this is a breaking change
either introduce a new rdb encoding version or undo this change.
There was a problem hiding this comment.
This isn't a breaking change. dlpack renamed this in their last release: https://github.com/dmlc/dlpack/releases
but the numeric value has not changed.
DvirDukhan
approved these changes
Jun 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store tensor of type bool as a sequence of bits, where the minimal size is one byte (as UINT8).
Add validation that we do not overflow the size of the type of the tensor when setting new tensor.