tag fix #781
Merged
tag fix #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 79.22% 78.92% -0.30%
==========================================
Files 50 50
Lines 7662 7721 +59
==========================================
+ Hits 6070 6094 +24
- Misses 1592 1627 +35
Continue to review full report at Codecov.
|
DvirDukhan
reviewed
Jun 9, 2021
| @@ -575,7 +575,7 @@ workflows: | |||
| - xenial | |||
| - bionic | |||
| lite: | |||
| - "REDISAI_LITE=0 publish" | |||
| - "REDISAI_LITE=0 publish PUSH_GENERAL=1 OFFICIAL=1" | |||
There was a problem hiding this comment.
why only in lite?
where is the branch/tag name instead of HEAD?
There was a problem hiding this comment.
When you operate on a branch, you have a legitimate name. Tags are detached HEADs, hence this change. This change lands here specifically, because we only push to dockerhub when LITE=0, as before. This can change....
DvirDukhan
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the docker tags on HEAD (i.e git tags), then fixing a force publish to dockerhub. This change is required in order to enable READIES to handle its tag + push flow.