Skip to content

Conversation

alonre24
Copy link
Collaborator

Add some protections for edge cases to avoid race conditions in the onnx kill switch

@alonre24 alonre24 requested a review from DvirDukhan June 24, 2021 10:13
@alonre24 alonre24 force-pushed the strengthen_onnx_kill_switch_sync branch from 0e0a7ab to ee1da7a Compare June 24, 2021 10:17
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #797 (1cd6692) into master (0000228) will increase coverage by 6.29%.
The diff coverage is 81.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   74.11%   80.40%   +6.29%     
==========================================
  Files          39       52      +13     
  Lines        6081     7886    +1805     
==========================================
+ Hits         4507     6341    +1834     
+ Misses       1574     1545      -29     
Impacted Files Coverage Δ
src/redis_ai_types/model_type.c 70.00% <ø> (ø)
src/redis_ai_types/script_type.c 70.00% <ø> (+5.00%) ⬆️
src/redis_ai_types/tensor_type.c 73.33% <ø> (ø)
src/serialization/AOF/rai_aof_rewrite.c 0.00% <0.00%> (ø)
tests/module/DAG_utils.c 88.23% <ø> (ø)
tests/module/LLAPI.c 74.46% <ø> (ø)
tests/unit/rmalloc.h 100.00% <ø> (ø)
tests/unit/unit_tests_err.cpp 100.00% <ø> (ø)
src/backends/libtflite_c/tflite_c.cpp 57.60% <35.71%> (ø)
src/backends/tflite.c 66.01% <57.14%> (+2.19%) ⬆️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de132ab...1cd6692. Read the comment docs.

@alonre24 alonre24 merged commit a0ad9d8 into master Jun 24, 2021
@alonre24 alonre24 deleted the strengthen_onnx_kill_switch_sync branch June 24, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants