-fcommon for gcc 10 minimal support #864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafie
reviewed
Oct 24, 2021
.circleci/config.yml
Outdated
| command: | | ||
| git submodule update --init opt/readies | ||
| ./opt/readies/bin/getpy3 | ||
| ./opt/readies/bin/getgcc --modern |
There was a problem hiding this comment.
it's better to place this in system-setup.py so every other context (docker etc) benefits from it.
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
==========================================
- Coverage 81.25% 81.21% -0.04%
==========================================
Files 54 54
Lines 8141 8145 +4
==========================================
Hits 6615 6615
- Misses 1526 1530 +4
Continue to review full report at Codecov.
|
rafie
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common flag for gcc10 minimal support