macos + clang build #897
Merged
macos + clang build #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
==========================================
+ Coverage 81.30% 81.38% +0.08%
==========================================
Files 54 54
Lines 8201 8210 +9
==========================================
+ Hits 6668 6682 +14
+ Misses 1533 1528 -5
Continue to review full report at Codecov.
|
chayim
previously approved these changes
Jan 16, 2022
chayim
reviewed
Mar 15, 2022
get_deps.sh
Outdated
| @@ -191,15 +199,20 @@ if [[ $OS == linux ]]; then | |||
| else | |||
| echo "Only x64 is supported currently" | |||
| fi | |||
| else | |||
| echo "Only Linux OS is supported currently" | |||
| if [[ $GPU != 1 ]]; then | |||
There was a problem hiding this comment.
Did you mean something else here? These two variables look identical.
chayim
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.