Enable saving run stats from low-level API #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt struct + move stats update to background worker (post process) from main thread
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
+ Coverage 81.30% 81.36% +0.06%
==========================================
Files 54 54
Lines 8201 8206 +5
==========================================
+ Hits 6668 6677 +9
+ Misses 1533 1529 -4
Continue to review full report at Codecov.
|
alonre24
commented
Mar 16, 2022
…ery subprocess to get a unique id
DvirDukhan
reviewed
Mar 17, 2022
… to logs (this has occurred when running with GPU)
DvirDukhan
reviewed
Apr 5, 2022
| @@ -15,6 +15,10 @@ int RAI_InitBackendTF(int (*get_api_fn)(const char *, void *)) { | |||
| get_api_fn("RedisModule_Realloc", ((void **)&RedisModule_Realloc)); | |||
| get_api_fn("RedisModule_Strdup", ((void **)&RedisModule_Strdup)); | |||
|
|
|||
| // Set min logging level to 3 (out of 5) - this is workaround since if TF is writing extensively | |||
| // log messages that to stderr, it may cause the system to be stuck. | |||
| RedisModule_Assert(putenv("TF_CPP_MIN_LOG_LEVEL=3") == 0); | |||
There was a problem hiding this comment.
I saw that it's working with 3 as well, so I left it like that (not really matters...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAI_RunStatsobject and APIThis also include some refactor of the
run_test_multiprocutil, that now allows every sub-process that represent a client to have a unique id (to enable some communications between the parent and children)