Skip to content

Add AI.CONFIG GET sub-command #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 30, 2022
Merged

Add AI.CONFIG GET sub-command #918

merged 9 commits into from
May 30, 2022

Conversation

alonre24
Copy link
Collaborator

Extend AI.CONFIG command with AI.CONFIG GET sub-command, that allows to retrieve the current BACKENDSPATH and MODEL_CHUNK_SIZE

@alonre24 alonre24 requested review from DvirDukhan and GuyAv46 May 25, 2022 07:59
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #918 (6252d1c) into master (2dd4ef1) will increase coverage by 0.44%.
The diff coverage is 96.12%.

@@            Coverage Diff             @@
##           master     #918      +/-   ##
==========================================
+ Coverage   81.30%   81.74%   +0.44%     
==========================================
  Files          54       54              
  Lines        8201     8219      +18     
==========================================
+ Hits         6668     6719      +51     
+ Misses       1533     1500      -33     
Impacted Files Coverage Δ
src/execution/DAG/dag_builder.c 100.00% <ø> (ø)
src/execution/DAG/dag_op.c 100.00% <ø> (ø)
src/execution/parsing/script_commands_parser.c 78.57% <ø> (-0.12%) ⬇️
.../serialization/RDB/decoder/previous/v2/decode_v2.c 46.37% <50.00%> (+0.45%) ⬆️
tests/module/LLAPI.c 75.89% <80.00%> (-0.02%) ⬇️
src/execution/background_workers.c 94.63% <94.73%> (+0.01%) ⬆️
src/redisai.c 89.08% <96.77%> (+1.29%) ⬆️
...backends/libtorch_c/torch_extensions/torch_redis.h 90.90% <100.00%> (ø)
src/backends/tensorflow.c 72.43% <100.00%> (+0.06%) ⬆️
src/execution/DAG/dag.c 91.50% <100.00%> (-0.28%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a66cb3...6252d1c. Read the comment docs.

Copy link
Collaborator

@DvirDukhan DvirDukhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
small comment

DvirDukhan
DvirDukhan previously approved these changes May 29, 2022
@alonre24 alonre24 added ci-test and removed ci-test labels May 29, 2022
@alonre24 alonre24 added ci-test and removed ci-test labels May 29, 2022
@alonre24 alonre24 merged commit 686d0c3 into master May 30, 2022
@alonre24 alonre24 deleted the add_ai_config_get_command branch May 30, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants