Skip to content

Conversation

jeffreylovitz
Copy link
Contributor

PR for service pack 2.2.9

jeffreylovitz and others added 14 commits November 30, 2020 16:02
* Validate number of RETURNs in UNION query

* Improve error handling and messages with invalid WHERE clauses

* Revert changes to optimize_cartesian_product

* Add run-time error for non-boolean predicate constants in runtime values

(cherry picked from commit ebfc507)
* improve graph loading time by noting multi-edge matices

* compute multi-edge only once

(cherry picked from commit 514fa25)
* Disallow property assignment to complex data types

* Address PR comments

* Capture errors before committing updates

Co-authored-by: Roi Lipman <[email protected]>
(cherry picked from commit 524f171)
* Don't assert on failed MERGE updates

* Update op_merge.c

Co-authored-by: Roi Lipman <[email protected]>
(cherry picked from commit b2dadd8)
* Disallow traversal patterns outside of the appropriate clauses

* Address PR comments

Co-authored-by: Roi Lipman <[email protected]>
(cherry picked from commit 0f53447)
* add redis-cli parameter example

I could not find how to set parameters on `redis-cli` on the documentation, so I added it here. Is there a better place? maybe https://oss.redislabs.com/redisgraph/commands/?

* * add a second parameter

to make it clear how to use more than a single parameter

Co-authored-by: Guy Korland <[email protected]>
(cherry picked from commit 3f19bd1)
* Fix warnings reported by fb-infer

* validate algebraic expression structure on evaluation

Co-authored-by: Roi Lipman <[email protected]>
Co-authored-by: swilly22 <[email protected]>
(cherry picked from commit eefb8ef)
CPP is the environment variable for the preprocessor executable, CXX specifies the compiler path.

(cherry picked from commit 88048ee)
* Disallow MERGE of entities with null properties

* Fix memory leak

* Move error-handling functions to errors.c

* Fix NULL serialization logic

* Address PR comments

* Address PR comments

* Move all error-handling logic to errors.c

* Fix memory leak

* Fix unit test

* Initialize ErrorCtx thread-local key

* reuse TLS error context, set and raise error in one call

* remove unused include

* Reset error breakpoint after every query

* Don't delete property update maps on encountering NULL values

* Add Valgrind suppression

* Expose ErrorCtx getter for identical logic in handler macro

Co-authored-by: Roi Lipman <[email protected]>
Co-authored-by: swilly22 <[email protected]>
(cherry picked from commit c972f72)
* new php client redislabs-redisgraph-php added

* columns are aligned.

* Update clients.md

* Update clients.md

Co-authored-by: Roi Lipman <[email protected]>
(cherry picked from commit bbd5993)
Co-authored-by: Guy Korland <[email protected]>
Co-authored-by: Roi Lipman <[email protected]>
(cherry picked from commit 081c863)
* validate clauses following a RETURN clause

* relocated return clause sequance validation

* Update ast_validations.c

(cherry picked from commit 2157919)
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request fixes 1 alert when merging 7249f24 into 4490185 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

gkorland and others added 2 commits December 2, 2020 09:52
(cherry picked from commit 682a5ba)
* switch from assert to debug assert

* Continue converting to debug assert

* Revert changes to RG.h

* switch from system assert to RedisModule_Assert

* re-order include sequence

Co-authored-by: Jeffrey Lovitz <[email protected]>
(cherry picked from commit 8345677)
* Add stars to clients

* Update clients.md

(cherry picked from commit b3e4222)
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request fixes 1 alert when merging 270040c into 4490185 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

* Don't recurse into previous scopes when optimizing Cartesian Products

* Fix crash on migrating cartesian products with constant filters

* Don't assert on non-filter branch head

* Avoid memory leak

* Fix memory leak

(cherry picked from commit 9b82f8b)
@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request fixes 1 alert when merging 819a1be into 6bac990 - view on LGTM.com

fixed alerts:

  • 1 for Comparison result is always the same

@swilly22 swilly22 merged commit 39c9b5f into 2.2 Dec 2, 2020
@swilly22 swilly22 deleted the 2-2-9-upversion branch December 2, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants