single writer threadpool #1565
Merged
single writer threadpool #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DvirDukhan
previously approved these changes
Feb 4, 2021
src/commands/cmd_context.c
Outdated
Comment on lines
68
to
71
| tid = thpool_num_threads(_thpool); | ||
| } else { | ||
| // +1 to compensate for Redis main thread | ||
| tid = thpool_get_thread_id(_thpool, pthread_self()) + 1; |
There was a problem hiding this comment.
AFAIU
for a pool with size 1
the reader thread will get tid=1 which is also thpool_num_threads
is it a problem here?
jeffreylovitz
previously approved these changes
Feb 4, 2021
src/slow_log/slow_log.c
Outdated
| @@ -13,14 +13,24 @@ | |||
| #include "../util/rmalloc.h" | |||
| #include "../util/thpool/thpool.h" | |||
|
|
|||
| extern threadpool _readers_thpool; // declared in module.c | |||
| extern threadpool _writers_thpool; // declared in module.c | |||
|
|
|||
| static int get_thread_id() { | |||
There was a problem hiding this comment.
Add explanatory comment like:
/* get_thread_id returns 0 for the Redis main thread,
* reader thread count + 1 for the writer thread,
* or reader thread ID for a reader thread. */
We should consider relocating this function to thpool.c, since it gets invoked here and by command_ctx.c (though thankfully nowhere else).
swilly22
dismissed stale reviews from jeffreylovitz and DvirDukhan
via
40e2891
swilly22
force-pushed
the
single-worker-threadpool
branch
from
20a865b to
2ec0eb2
Compare
swilly22
force-pushed
the
single-worker-threadpool
branch
from
09a0612 to
176eacd
Compare
swilly22
added a commit
that referenced
this pull request
Feb 8, 2021
* single writer threadpool * name read and writer threads * maintain both readers and writers thread pools under a single pools object
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* single writer threadpool * name read and writer threads * maintain both readers and writers thread pools under a single pools object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.