Use file streaming endpoint to parse queries #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swilly22
previously approved these changes
Feb 13, 2021
tests/flow/test_query_validation.py
Outdated
| # Test a query that allocates a large buffer. | ||
| def test35_large_query(self): | ||
| retval = "abcdef" * 1_000 | ||
| query = """RETURN """ + "'" + retval + "'" |
There was a problem hiding this comment.
query = "RETURN " + "'" + retval + "'"
swilly22
approved these changes
Feb 13, 2021
This was referenced Feb 13, 2021
Closed
swilly22
added a commit
that referenced
this pull request
Feb 14, 2021
* Use file streaming endpoint to parse queries * Revert change to default parse buffer size * Address PR comments Co-authored-by: Roi Lipman <[email protected]>
swilly22
added a commit
that referenced
this pull request
Feb 16, 2021
* Avoid postponed array (#1569) * WIP * persist projected values * remove emit record * Lock on write proc (#1573) * write lock when invoking write procedure * replicate index modifications * Use file streaming endpoint to parse queries (#1572) * Use file streaming endpoint to parse queries * Revert change to default parse buffer size * Address PR comments Co-authored-by: Roi Lipman <[email protected]> Co-authored-by: Jeffrey Lovitz <[email protected]>
pnxguide
pushed a commit
to CMU-SPEED/RedisGraph
that referenced
this pull request
Mar 22, 2023
* Use file streaming endpoint to parse queries * Revert change to default parse buffer size * Address PR comments Co-authored-by: Roi Lipman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves erroneous query rejections due to buffer overflows.
#760 #1486