Skip to content

Incorrect INFO value from DLASQ2 #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vladimir-ch opened this issue Feb 19, 2019 · 1 comment · Fixed by #506
Closed

Incorrect INFO value from DLASQ2 #325

vladimir-ch opened this issue Feb 19, 2019 · 1 comment · Fixed by #506

Comments

@vladimir-ch
Copy link
Contributor

This is a very minor issue.

The documentation for DLASQ2 says that

*>  ... if the i-th argument is an
*>             array and the j-entry had an illegal value, then
*>             INFO = -(i*100+j)

When the code checks elements of Z (the second parameter), INFO is set according to this except for the following case at line 187:

         IF( Z( 2 ).LT.ZERO .OR. Z( 3 ).LT.ZERO ) THEN
            INFO = -2
            CALL XERBLA( 'DLASQ2', 2 )
            RETURN

INFO should be -202 and -203 respectively.
@vladimir-ch
Copy link
Contributor Author

Also, the code does not check whether Z(1) is negative when N.EQ.2, it probably could/should.

@julielangou julielangou mentioned this issue Mar 4, 2021
Merged
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this issue May 23, 2021
@julielangou
Fix Incorrect INFO value from SLASQ2 and DLASQ2
7b011ef 
When the code checks elements of Z (the second parameter), INFO should be set according to the following
"if the i-th argument is an array and the j-entry had an illegal value, then INFO = -(i*100+j)"

Updated 2-by-2 case - adjusted value and added Z(1) check.

Will close Reference-LAPACK#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Incorrect INFO value from SLASQ2 and DLASQ2
1 participant
@vladimir-ch