Skip to content

Implicit typing #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thijssteel opened this issue Feb 10, 2021 · 2 comments · Fixed by #486
Closed

Implicit typing #484

thijssteel opened this issue Feb 10, 2021 · 2 comments · Fixed by #486
Milestone
LAPACK 3.9.1

Comments

@thijssteel
Copy link
Collaborator

@weslleyspereira recently found a typo in a PR of mine, a typo that would have been impossible without implicit typing.

It would surprize me if any of the routines actually used implicit typing, so it probably always points to a bug.

I propose that we add IMPLICIT NONE to all the subroutines. Or perhaps add -fimplicit-none to the CI.
@thijssteel
Copy link
Collaborator Author

apparently, i made another mistake with implicit typing in one of my first PR's, i'll make a fix soon.

@weslleyspereira
Copy link
Collaborator

Thanks @thijssteel ! I think using the flag -fimplicit-none is the best first option since it is less intrusive.

@weslleyspereira weslleyspereira mentioned this issue Feb 11, 2021
Merged
weslleyspereira added a commit that referenced this issue Feb 12, 2021
@weslleyspereira
Merge pull request #486 from weslleyspereira/try-implicit-none
6281084 
Summary of PR #486:
1. There was a bug in the Makefile, and this is why AppVeyor stopped working. I solved it.
2. A recent commit was caused by a variable that was not defined, and the compiler couldn't track it. @thijssteel suggested adding `-fimplicit-none` to the CI on #484. I did it.
@julielangou julielangou added this to the LAPACK 3.9.1 milestone Mar 25, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this issue May 23, 2021
@weslleyspereira
Merge pull request Reference-LAPACK#486 from weslleyspereira/try-impl…
fbdd359 
…icit-none

Summary of PR Reference-LAPACK#486:
1. There was a bug in the Makefile, and this is why AppVeyor stopped working. I solved it.
2. A recent commit was caused by a variable that was not defined, and the compiler couldn't track it. @thijssteel suggested adding `-fimplicit-none` to the CI on Reference-LAPACK#484. I did it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
LAPACK 3.9.1
Development

Successfully merging a pull request may close this issue.

Try implicit none weslleyspereira/lapack
3 participants
@weslleyspereira @julielangou @thijssteel