Skip to content

[BLAS] Remove unused NCOLA variable #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

timleslie
Copy link
Contributor

The variable NCOLA was computed but not used in the files *gemm.f, This PR removes this variable and updates the appropriate comments.

@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #449 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   81.86%   81.77%   -0.10%     
==========================================
  Files        1863     1863              
  Lines      181062   179982    -1080     
==========================================
- Hits       148229   147178    -1051     
+ Misses      32833    32804      -29     
Impacted Files Coverage Δ
SRC/dlagv2.f 72.34% <0.00%> (-7.45%) ⬇️
SRC/zlat2c.f 64.70% <0.00%> (-6.73%) ⬇️
SRC/icmax1.f 55.55% <0.00%> (-4.45%) ⬇️
SRC/izmax1.f 55.55% <0.00%> (-4.45%) ⬇️
SRC/slarrb.f 88.04% <0.00%> (-3.45%) ⬇️
SRC/cunm22.f 54.54% <0.00%> (-2.45%) ⬇️
SRC/dorm22.f 54.54% <0.00%> (-2.45%) ⬇️
SRC/zunm22.f 54.54% <0.00%> (-2.45%) ⬇️
INSTALL/lsame.f 57.89% <0.00%> (-2.11%) ⬇️
SRC/clamswlq.f 77.92% <0.00%> (-2.08%) ⬇️
... and 337 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b2211...50781b7. Read the comment docs.

@martin-frbg
Copy link
Collaborator

Bet the management of Nitro-Cola (or was it Nuclear Cola ?) will hate you for this - the unused variable must have been there for something like 12 years at least.(I do note that not even gfortran10 -Wunused-but-set-variable
would flag this - was this from visual inspection or did some other compiler complain ?)

@timleslie
Copy link
Contributor Author

This was from visual inspection. I'm amazed this wasn't flagged by compiler warnings too! 🤷

@JHenneberg
Copy link

nice catch

@martin-frbg martin-frbg merged commit 122506c into Reference-LAPACK:master Sep 29, 2020
@timleslie timleslie deleted the remove-ncola branch September 30, 2020 08:14
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants