Fix ieee check and ilaenv -- fix issue #479 and issue #435 #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @weslleyspereira
If you call ILAENV(10, ...), it will check IEEE Infinity and IEEE NaN behavior. No need to call ILAENV(11, ...) Note that the call to IEEE = ( ILAENV( 10, 'SLASQ2', 'N', 1, 2, 3, 4 ).EQ.1 ) in SLASQ2 is commented out with the following comment: * * [11/15/2008] The case IEEE=.TRUE. has a problem in single precision with * some the test matrices of type 16. The double precision code is fine. * and IEEE is set to .FALSE. This commit does not address this
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 1820 1820
Lines 170857 170857
=======================================
Hits 142384 142384
Misses 28473 28473
Continue to review full report at Codecov.
|
This was referenced Mar 2, 2021
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
…ee-check--ilaenv--issue479--issue435 Fix ieee check and ilaenv -- fix issue Reference-LAPACK#479 and issue Reference-LAPACK#435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks @weslleyspereira