-
Notifications
You must be signed in to change notification settings - Fork 466
Use dynamic allocation in the LIN tests as well #553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamic allocation in the LIN tests as well #553
Conversation
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 1894 1894
Lines 190677 190677
=======================================
Hits 157063 157063
Misses 33614 33614 Continue to review full report at Codecov.
|
Amazing, thanks for the super quick handling @martin-frbg! 🙃 I tested a squashed version of this branch in conda-forge/lapack-feedstock#51 (without the manual stack size increase), and the test suite passes! 🥳 |
@weslleyspereira |
I can merge it already if you are so eager to get it 😃 |
didn't know that waiting 3 days still qualifies as eagerness** 😅 there's no reason to rush. ** though I guess that I am looking forward to buttoning up conda-forge/lapack-feedstock#51, which has been something I wanted to finish for ~2 month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weslleyspereira
Would you be able to have a look? upside_down_face
Oh! Sorry... I was lazy on that one. :) It seems all good to me.
I forgot to say... thanks, @martin-frbg! |
And thanks for the quick review @langou @weslleyspereira! 😊 |
Use dynamic allocation in the LIN tests as well
copies the changes from #492 to fix #548