Skip to content

Use dynamic allocation in the LIN tests as well #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2021

Conversation

martin-frbg
Copy link
Collaborator

copies the changes from #492 to fix #548

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #553 (96db3e4) into master (2dafa3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files        1894     1894           
  Lines      190677   190677           
=======================================
  Hits       157063   157063           
  Misses      33614    33614           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dafa3d...96db3e4. Read the comment docs.

h-vetinari added a commit to h-vetinari/lapack-feedstock that referenced this pull request May 14, 2021
@h-vetinari
Copy link
Contributor

Amazing, thanks for the super quick handling @martin-frbg! 🙃

I tested a squashed version of this branch in conda-forge/lapack-feedstock#51 (without the manual stack size increase), and the test suite passes! 🥳

@langou langou self-requested a review May 14, 2021 18:33
@h-vetinari
Copy link
Contributor

@weslleyspereira
Would you be able to have a look? 🙃

@martin-frbg
Copy link
Collaborator Author

I can merge it already if you are so eager to get it 😃

@h-vetinari
Copy link
Contributor

didn't know that waiting 3 days still qualifies as eagerness** 😅

there's no reason to rush.

** though I guess that I am looking forward to buttoning up conda-forge/lapack-feedstock#51, which has been something I wanted to finish for ~2 month.

Copy link
Collaborator

@weslleyspereira weslleyspereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weslleyspereira
Would you be able to have a look? upside_down_face

Oh! Sorry... I was lazy on that one. :) It seems all good to me.

@weslleyspereira weslleyspereira merged commit 9d85169 into Reference-LAPACK:master May 17, 2021
@weslleyspereira
Copy link
Collaborator

I forgot to say... thanks, @martin-frbg!

@h-vetinari
Copy link
Contributor

And thanks for the quick review @langou @weslleyspereira! 😊

h-vetinari added a commit to h-vetinari/lapack-feedstock that referenced this pull request May 17, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
Use dynamic allocation in the LIN tests as well
@julielangou julielangou added this to the LAPACK 3.10.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackoverflow for xlintstz_ztest_in under 3.9.1 on windows
5 participants