Skip to content

Improving comments in GELQT3, LAPY2 and LAPY3 routines #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

weslleyspereira
Copy link
Collaborator

@weslleyspereira weslleyspereira commented Jun 3, 2021

Description
Adds the text
"taking care not to cause unnecessary overflow or unnecessary underflow."
to better describe the algorithms LAPY2 and LAPY3.

[edited]
Also, fixes comments in GELQT3.
Closes #574

langou
langou previously approved these changes Jun 3, 2021
@codecov
Copy link

codecov bot commented Jun 3, 2021

Codecov Report

Merging #573 (df138ae) into master (bd6add2) will not change coverage.
The diff coverage is n/a.

❗ Current head df138ae differs from pull request most recent head 8fca89b. Consider uploading reports for the commit 8fca89b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #573   +/-   ##
=======================================
  Coverage   82.37%   82.37%           
=======================================
  Files        1894     1894           
  Lines      190679   190679           
=======================================
  Hits       157065   157065           
  Misses      33614    33614           
Impacted Files Coverage Δ
SRC/dlapy2.f 100.00% <ø> (ø)
SRC/dlapy3.f 88.88% <ø> (ø)
SRC/slapy2.f 100.00% <ø> (ø)
SRC/slapy3.f 88.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd6add2...8fca89b. Read the comment docs.

@weslleyspereira weslleyspereira changed the title Improves the comments in LAPY2 and LAPY3 routines Improving comments in GELQT3, LAPY2 and LAPY3 routines Jun 4, 2021
@langou langou merged commit 53a49de into Reference-LAPACK:master Jun 4, 2021
@julielangou julielangou added this to the LAPACK 3.10.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DGELQT3 - documentation issue
3 participants