Fix CBLAS xerbla following hidden strlen argument changes #619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commits 2d9fbde and 628a209 changed the function prototypes in the cblas_f77.h. However, the F77_xerbla case was not treated in the same way as the others. In particular, the consequence is now that the xerbla function provided by the CBLAS/src/xerbla.c file is never called at runtime (because it is identified as “F77_xerbla” in the symbol table, instead of simply “xerbla”, since F77_xerbla is *not* a macro). This patch restores the symmetry between xerbla and the other functions.
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1894 1894
Lines 184021 184021
=======================================
Misses 184021 184021 Continue to review full report at Codecov.
|
langou
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits 2d9fbde and
628a209 changed the function prototypes in the
cblas_f77.h.
However, the F77_xerbla case was not treated in the same way as the others. In
particular, the consequence is now that the xerbla function provided by the
CBLAS/src/xerbla.c file is never called at runtime (because it is identified as
“F77_xerbla” in the symbol table, instead of simply “xerbla”, since F77_xerbla
is not a macro).
This patch restores the symmetry between xerbla and the other functions.
Note that I have applied this patch to the official Debian package. If you think this is the wrong way of fixing this, please let me know.
Cc @eshpc @weslleyspereira