Skip to content

CMake: avoid "make" in blas++ & lapack++ #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Apr 18, 2023

Description

Replace make and make install by cmake --build and cmake --install, for cases where make is not available and/or CMAKE_GENERATOR is set to eg. Ninja.

In my case, this fix the following error:

[1631/6872] Performing build step for 'blaspp'
  FAILED: blaspp-prefix/src/blaspp-stamp/blaspp-build …/bld/blaspp-prefix/src/blaspp-stamp/blaspp-build
  cd …/bld/blaspp-prefix/src/blaspp-build && …/lib/python3.8/site-packages/cmake/data/bin/cmake -E env LIBRARY_PATH=:…/bld/lib LIB_SUFFIX=\"\" make && …/lib/python3.8/site-packages/cmake/data/bin/cmake -E touch …/bld/blaspp-prefix/src/blaspp-stamp/blaspp-build
  make: *** No targets specified and no makefile found. Stop.

Checklist

  • The documentation has been updated.
  • If the PR solves a specific issue, it is set to be closed on merge.

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e860053) 0.00% compared to head (99a4e25) 0.00%.

❗ Current head 99a4e25 differs from pull request most recent head 5ca8851. Consider uploading reports for the commit 5ca8851 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage    0.00%    0.00%           
=======================================
  Files        1908     1908           
  Lines      186958   186958           
=======================================
  Misses     186958   186958           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nim65s nim65s mentioned this pull request Apr 18, 2023
2 tasks
Copy link
Collaborator

@weslleyspereira weslleyspereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Tests failing on AppVeyor are not related to this PR.

@langou langou merged commit 3c858f7 into Reference-LAPACK:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants