-
Notifications
You must be signed in to change notification settings - Fork 4
Refactored the tests to use the github action #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@miazamrai so we don't need to redefine |
Yes, the other repository workflow will checkout the sdk and directly run the action from the sdk’s action folder. |
Don't you need to (optionally) pass in the engine version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @miazamrai
it will be like this. |
Is there a reason not to make the engine version (or perhaps custom headers) an explicit input? It would make the action self documenting. As it is now, callers of this action need to know the special environment variable to set. |
I opted the env variable approach for the following reasons,
|
@larf311 If you are agree with the current approach then I will merge this to main. |
|
I like #4 |
@larf311 Added the custom headers input param. |
Moved the test code to be called as github action so that the source for testing via the python sdk resides on a single place. It will allow the consumers to absorb any changes made to the test logic.