Skip to content

Add suspend/resume engine to the api #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2024
Merged

Add suspend/resume engine to the api #150

merged 3 commits into from
Apr 4, 2024

Conversation

Akrion
Copy link
Member

@Akrion Akrion commented Apr 4, 2024

  • Added suspend & resume to the engines api
  • Added examples
  • Updated change log and versions

@Akrion Akrion self-assigned this Apr 4, 2024
meruyert93
meruyert93 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@meruyert93 meruyert93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! codewise looks good to me 👍🏻

vilterp
vilterp reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@vilterp vilterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish engines would unsuspend themselves when you run queries against them, like Snowflake's virtual warehouses do. But in the meantime, might as well

@Akrion Akrion requested a review from vilterp April 4, 2024 21:01
@Akrion Akrion merged commit a218395 into main Apr 4, 2024
@Akrion Akrion deleted the ia-suspend-resume branch April 4, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meruyert93 meruyert93 meruyert93 approved these changes

@ibdknox ibdknox Awaiting requested review from ibdknox

@joshuafcole joshuafcole Awaiting requested review from joshuafcole

@bradlo bradlo Awaiting requested review from bradlo

@sswatson sswatson Awaiting requested review from sswatson

+1 more reviewer

@vilterp vilterp vilterp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Akrion Akrion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akrion @vilterp @meruyert93