[RAI-25151]: Fix polling duration in poll_with_specified_overhead function

[meruyert93]

Fix polling duration calculation in poll_with_specified_overhead function.

It resolves RAI-25151

[vilterp]

Definitely looks more like the Julia one now…

This is making me wish Python had fake-able timers like Jest, so we could write a nice test for this! 😅

[meruyert93]

This is making me wish Python had fake-able timers like Jest, so we could write a nice test for this! 😅

yeah agree that would be indeed nice 😄

[vilterp]

It looks like there is https://docs.python.org/3/library/unittest.mock.html

Maybe you could try using that to write a small unit test for poll_with_specified_overhead, like we did for the profiler poller? Since this logic is important for performance and has caused bugs in the past, it'd be nice to have it under test.

[meruyert93]

@vilterp it actually had couple tests, now I have added more tests

[vilterp]

Hm, looks like tests failing with

Exception: max tries 1 exhausted

[meruyert93]

@vilterp all the tests are passed. Where do you see it?

[meruyert93]

@vilterp
it was failing with Exception: max tries 1 exhausted here: https://github.com/RelationalAI/rai-sdk-python/pull/151/files#diff-f4c8f93a330162e591e147d72a2dba80b81510662e5608f2d130bf63d5220ed7R33 However, I already fixed it:
I increased max_tries so that the function doesn't exit on the first iteration. Then sse a try except block to catch the exception but still check the behavior of time.sleep, because the goal of this test is to test initial delay.

[vilterp]

Oh ok, I guess the github UI didn't refresh itself and I was looking at an out of date run. Will review again on Mon

[vilterp]

Apologies for taking so long on this!