This repository was archived by the owner on Mar 29, 2021. It is now read-only.
Support detecting simulator #160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ios-webkit-debug-proxy supports passing a unix socket as the -s command flag, by allowing people to pass a simulator udid we can lookup this socket in lsof and then pass that into iwdb
auchenberg
reviewed
Jul 17, 2019
| debug(`iOSAdapter.getSimulatorUnixSocket`); | ||
| return new Promise(async (resolve, reject) => { | ||
| try { | ||
| const { stdout } = await exec('lsof -aUc launchd_sim'); |
There was a problem hiding this comment.
Does this also work on Windows?
There was a problem hiding this comment.
Dah, no Emulator on Windows, maybe bail if not MacOS?
|
Few nits, otherwise LGTM! |
|
This project is now super-seeded by https://inspect.dev/ – a new developer tool for macOS and Windows to inspect and debug your web apps and websites in Safari and WebViews on iOS devices. RemoteDebug iOS WebKit Adapter is not proactively maintained or extended. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google/ios-webkit-debug-proxy#306 introduced passing the simulator web inspector socket in to ios_webkit_debug_proxy. The socket can be looked up using
lsof -aUc launchd_simand finding the matching socket based off the provided UDID, I went this route (as opposed to a user providing the socket) as I figured it would be easier to find the UDID.This is still pretty rough (exception handling could be improved), but I wanted to push a PR early to see whether this would be a welcome addition
This also requires [email protected]