Skip to content

added drawing activities #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bendhouseart
Copy link

This PR corresponds to PR #363 and adds two drawing activities to the demo protocol.

@yibeichan
Copy link
Collaborator

@djarecka hey, we are adding drawing to UI (see this ReproNim/reproschema-ui#363 ) and so have a new input which couldn't pass the validation. i guess we need to modify the validate function a bit to adjust for this change?

@djarecka
Copy link
Member

@bendhouseart - I was checking our schema, and it seems like we already have a property that might work for you. Each Item in reproschema can have image property, and the value can be either uri or ImageObject.

Do you think you can reuse this property in reproschema-ui for the drawing input, instead of adding an additional one?

@bendhouseart
Copy link
Author

bendhouseart commented Jun 25, 2025

@djarecka maybe? My first thoughts were to set backgroundImage via Vue and I just used the most straight forward method to do that. see -> https://github.com/ReproNim/reproschema-ui/blob/be784b66ae8d8a158853f70f857a74c5d0c18eec/src/components/CanvasInput.vue#L28

My reasoning was: align reproschema with Vue/CSS/html versus the other way round. However, if we're able to draw over an image element and separate that drawing it shouldn't be an issue. E.g. I'd like to keep things such that the background image remains distinct from "value": { "imageData": .....} in the jsonld for each response.

Would you be willing to merge this for now and then try to reuse the image property in place of backgroundImage for the next iteration? I've tested this in my own janky setup, but it'd be nice to show that it can work on the live version of the demoprotocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants