Skip to content

Conversation

lch
Copy link
Collaborator

@lch lch commented Mar 24, 2025

According to the merged PR JuliaLang/julia#57311, all types should be imported explicitly. Otherwise, starting from Julia version 1.12.0, the compiler will generate a warning message during the precompilation process, which has been observed in the recent CI test on julia nightly. This PR should fix the problem.

Copy link
Collaborator

@joachimbrand joachimbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you this looks great!

I noticed that the usual tests did not run due to our CI setup. I tried to change that. Can you please pull RimuQMC:develop. That should fix it and tests should run on nightly.

@coveralls
Copy link

coveralls commented Mar 26, 2025

Pull Request Test Coverage Report for Build 14083177255

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.785%

Totals Coverage Status
Change from base Build 14081460856: 0.0%
Covered Lines: 6888
Relevant Lines: 7267

💛 - Coveralls

Copy link
Collaborator

@joachimbrand joachimbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@joachimbrand joachimbrand merged commit 9d633aa into RimuQMC:develop Mar 26, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants