Skip to content

README: Add information about Drake's fork #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Jan 14, 2020

This includes a process for merging PRs.


This change is Reviewable

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jwnimmer-tri and +@jamiesnape for review, please?

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @jamiesnape and @jwnimmer-tri)

Copy link

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good so far. I'll test out the recipes soon.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @EricCousineau-TRI and @jamiesnape)


README_DRAKE.md, line 23 at r1 (raw file):

* [User: Python Bindings](https://drake.mit.edu/python_bindings.html#using-the-python-bindings)
* [Dev: Python Bindings](https://drake.mit.edu/doxygen_cxx/group__python__bindings.html)
* [User: API Reference](https://drake.mit.edu/pydrake/index.html#://)

nit I don't think we need the duck emoticon (#://) at the end here?


README_DRAKE.md, line 60 at r1 (raw file):

Windows testing (with AppVeyor) is disabled for this repository.

## Local Git Setup

Somewhere in this README, I'd like to see a description of any branches and tags that exist on RobotLocomotion/pybind11 that are not already mentioned in the document.

(This would be easier if we purge all of the vestigial branches and tags that have no more reason to exist.)

Copy link

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: pending discussions.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @EricCousineau-TRI and @jamiesnape)


README_DRAKE.md, line 69 at r1 (raw file):

    git clone --origin upstream https://github.com/pybind/pybind11
    cd pybind11
    git remote --set-url --push upstream no_push

nit Just set-url not --set-url. Ditto a few lines below.

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jamiesnape and @jwnimmer-tri)


README_DRAKE.md, line 60 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Somewhere in this README, I'd like to see a description of any branches and tags that exist on RobotLocomotion/pybind11 that are not already mentioned in the document.

(This would be easier if we purge all of the vestigial branches and tags that have no more reason to exist.)

Done.

I'll go ahead and purge the following branches / tags, unless you object:
upstream, upstream_new, last_sha_of_previous_fork (branch and tag)

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jamiesnape and @jwnimmer-tri)


README_DRAKE.md, line 60 at r1 (raw file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Done.

I'll go ahead and purge the following branches / tags, unless you object:
upstream, upstream_new, last_sha_of_previous_fork (branch and tag)

Oh, and master. I'll set drake to the default branch after this merges.

Copy link

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jamiesnape)


README_DRAKE.md, line 60 at r1 (raw file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Oh, and master. I'll set drake to the default branch after this merges.

Fine by me. (Dunno if you have to consult anyone else?)

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jamiesnape)


README_DRAKE.md, line 60 at r1 (raw file):

Previously, jwnimmer-tri (Jeremy Nimmer) wrote…

Fine by me. (Dunno if you have to consult anyone else?)

OK I've already asked Jamie about re-setting some branches, so should be good to go.

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-@jamiesnape for now, can fix things afterwards

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@EricCousineau-TRI EricCousineau-TRI merged commit 212cfb9 into RobotLocomotion:drake Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants