Skip to content

drake: Workaround "Assertion '!PyErr_Occurred()'" for dtype=object #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Mar 5, 2021

Resolves RobotLocomotion/drake#14740

Mimics solution from pybind#2685 based on this stacktrace:
https://gist.github.com/EricCousineau-TRI/a60c2ba37eb7db04c183f5be81a267b0


This change is Reviewable

@EricCousineau-TRI
Copy link
Collaborator Author

EricCousineau-TRI commented Mar 5, 2021

To test:

sudo apt install python3.8-dev python3.8-venv python3.8-dbg

cd pybind11
(
set -eux;
git clean -fxd  # WARNING!
python3.8-dbg -m venv ./venv
source ./venv/bin/activate
pip install -U pip wheel
pip install pytest numpy scipy
mkdir build && cd build
cmake .. -GNinja \
    -DCMAKE_BUILD_TYPE=Debug \
    -DPYTHON_EXECUTABLE=$(which python)
ninja pytest
)

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@jamiesnape for review, please!

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jamiesnape)

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI and @jamiesnape)

a discussion (no related file):
Working: Requires Drake PR. Will do so once existing pybind11 upgrades land.


Copy link

@jamiesnape jamiesnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)

a discussion (no related file):

Previously, EricCousineau-TRI (Eric Cousineau) wrote…

Working: Requires Drake PR. Will do so once existing pybind11 upgrades land.

Done: RobotLocomotion/drake#14751


@EricCousineau-TRI EricCousineau-TRI merged commit e940bf8 into RobotLocomotion:drake Mar 8, 2021
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pybind11: Should ensure that python3.8-dbg doesn't cause segfault on Linux?
2 participants