Segfault when `open`ing (and closing) the controller more than once

[zohnannor]

If I run this code:

fn main() {
    let sdl2 = sdl2::init().unwrap();
    let gcs = sdl2.game_controller().unwrap();

    let gamepad = gcs.open(0).unwrap();
    drop(gamepad); // <--------
    let gamepad = gcs.open(0).unwrap();
    drop(gamepad);
    drop(gcs);
    drop(sdl2);
}

Segmentation fault

If I remove marked line (drop for the first instance of 0th gamepad), then Segmentation fault doesn't happen.

To be completely honest, I have no idea how that prevents the segfault.

---

Cargo.toml:

sdl2 = { version = "0.38.0", features = ["bundled", "hidapi", "static-link"] }

OS: Windows 10
shell: Git Bash

[zohnannor]

This is likely a bug in the upstream.

fn main() {
    let res = unsafe { sdl2::sys::SDL_Init(0) };
    assert!(res == 0);
    let res = unsafe { sdl2::sys::SDL_InitSubSystem(SDL_INIT_GAMECONTROLLER) };
    assert!(res == 0);
    let gamepad1 = unsafe { SDL_GameControllerOpen(0) };
    assert!(!gamepad1.is_null());
    unsafe { SDL_GameControllerClose(gamepad1) }; // <-------
    let gamepad = unsafe { SDL_GameControllerOpen(0) };
    assert!(!gamepad.is_null());
    unsafe { SDL_GameControllerClose(gamepad) };
    unsafe { SDL_QuitSubSystem(SDL_INIT_GAMECONTROLLER) };
    unsafe { SDL_Quit() };
}

The code above produces the same results. Removing marked line prevents segfault.

[zohnannor]

When I build https://github.com/libsdl-org/SDL/tree/SDL2 and use the dll, segfault doesn't happen 🤔

[zohnannor]

Yeah, this seems to be fixed in upstream.

Confirmed by doing this:

diff --git a/.gitmodules b/.gitmodules
index 817ab7e7..81384f48 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,3 +1,4 @@
 [submodule "sdl2-sys/SDL"]
        path = sdl2-sys/SDL
        url = https://github.com/libsdl-org/SDL
+       branch = SDL2
diff --git a/sdl2-sys/SDL b/sdl2-sys/SDL
index 07d0f51f..f201b64f 160000
--- a/sdl2-sys/SDL
+++ b/sdl2-sys/SDL
@@ -1 +1 @@
-Subproject commit 07d0f51fa292895443f563f0cbde4cb3802d87fa
+Subproject commit f201b64ffe1380713b181a3421c7fd910c95aada

(git submodule update --remote after adding the branch parameter to the submodule)

[zohnannor]

This was fixed in libsdl-org/SDL@cdc40ee. (Confirmed by git bisecting)

This issue would be fixed by merging #1496.