Skip to content

replaces uses of extra::sort::quick_sort in keycode/scancode #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

olsonjeffery
Copy link
Contributor

it's a christmas miracle (fixes failing travis build against current master)

@darthdeus
Copy link

I've tried pulling in this PR but the build still fails for me with the following

➤ make
rustpkg install codegen  --cfg mac_framework
WARNING: The Rust package manager is experimental and may be unstable
note: Installed package codegen-0.0 to /Users/darth/projects/rust/game/rust-sdl2
bin/codegen keycode.rs src/sdl2/generated/
bin/codegen scancode.rs src/sdl2/generated/
rustpkg build sdl2  --cfg mac_framework
WARNING: The Rust package manager is experimental and may be unstable
/Users/darth/projects/rust/game/rust-sdl2/src/sdl2/lib.rs:1:0: 4:57 error: obsolete crate `link` attribute
/Users/darth/projects/rust/game/rust-sdl2/src/sdl2/lib.rs:1 #[link(name = "sdl2",
/Users/darth/projects/rust/game/rust-sdl2/src/sdl2/lib.rs:2        vers = "0.0.1",
/Users/darth/projects/rust/game/rust-sdl2/src/sdl2/lib.rs:3        uuid = "263e35b2-0727-11e3-b3dd-29219a890b3c",
/Users/darth/projects/rust/game/rust-sdl2/src/sdl2/lib.rs:4        url = "http://github.com/AngryLawyer/rust-sdl2")];
note: the link attribute has been superceded by the crate_id attribute, which has the format `#[crate_id = "name#version"]`
error: aborting due to previous error
task '<unnamed>' failed at 'explicit failure', /private/tmp/rust-QlWa/src/libsyntax/diagnostic.rs:102
task '<unnamed>' failed at 'receiving on a closed channel', /private/tmp/rust-QlWa/src/libstd/comm/mod.rs:749
make: *** [libsdl2.dummy] Error 65

@emberian
Copy link
Contributor

Unrelated failure; simple to fix.

@emberian
Copy link
Contributor

(Read the error message)

@emberian emberian mentioned this pull request Dec 25, 2013
Cobrand pushed a commit that referenced this pull request Dec 2, 2016
Rework rendering (again), rename functions, improve documentation and more general mayhem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants