Fix some things for new rust version #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ups I should have checked the pull requests first. Didn't know about #31. |
|
|
AngryLawyer
added a commit
that referenced
this pull request
Jan 8, 2014
Fix some things for new rust version
|
Cheers for that, looks great |
Cobrand
pushed a commit
that referenced
this pull request
Dec 2, 2016
Sdl2MixerContext is created with init, and has drop implemented. This means that it will automatically drop at the end, after Music would drop, solving Issue #32. Additionally, I also changed init to check returned flags and produce an error if every single flag is not initialized. This is what InitFlags.to_string() is for. I also updated examples/demo.rs to work with these new changes. Finally, I added some documentation and tweaked some functions slightly. I also ran rustfmt on the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to make rust-sdl2 work with latest rust master.
It seems that libnative doesn't work with
rustpkgyet. I had to dobefore it compiles.