Address io::io_error removal #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful. Don't worry too much about the warnings; create a github issue for it and we'll solve it at some point. |
AngryLawyer
added a commit
that referenced
this pull request
Feb 5, 2014
Address io::io_error removal
Cobrand
pushed a commit
that referenced
this pull request
Dec 2, 2016
Make Font never outlive its RWops anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust PR: rust-lang/rust#11946
Description of changes:
src/codegen/{keycode.rs,scancode.rs}:for..inexpects a result type of(); with the IO changes all theWritermethods now returnIoResult<()>, so a trailing;is required.src/codegen/main.rs:open_modereturns anIoResult<File>(an alias forResult<File, IoError>), soSome/Noneneed to be replaced withOk/Err.An unfortunate side effect of this change is that there are now a bunch of warnings during compilation because nothing is being done with the
IoResults:warning: unused result which must be used, #[warn(unused_must_use)] on by defaultI haven't done anything to address this because I'm not sure what the best course of action is.