Skip to content

Preview of Binder IPC driver in Rust. #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2021
Merged

Preview of Binder IPC driver in Rust. #174

merged 3 commits into from
Apr 11, 2021

Conversation

wedsonaf
Copy link

No description provided.

ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
Copy link
Member

@ojeda ojeda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

A quick few comments. In general, it looks fine for the RFC.

ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
Copy link
Member

@ojeda ojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #120 is now in, you will need to change the println!s, which the CI didn't catch because it is not enabled in the configs :)

@wedsonaf
Copy link
Author

I squashed all the commits into one and rebased.

ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
ojeda
ojeda reviewed Apr 11, 2021
View reviewed changes
ojeda
ojeda approved these changes Apr 11, 2021
View reviewed changes
Copy link
Member

@ojeda ojeda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I see you changed the file_operations bits we discussed the other day to unsafe, so it is fine.

I let @alex merge in case he wants to take a better look.

alex
alex reviewed Apr 11, 2021
View reviewed changes
Copy link
Member

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only really reviewed the rust/kernel/ part of this, but it looks ok to me. Can we please file a follow-up task to make the mmap API more idiomatic?

@ojeda ojeda merged commit 2bd985a into Rust-for-Linux:rust Apr 11, 2021
@wedsonaf wedsonaf deleted the binder branch April 11, 2021 22:35
@wedsonaf
Copy link
Author

I only really reviewed the rust/kernel/ part of this, but it looks ok to me. Can we please file a follow-up task to make the mmap API more idiomatic?

#178 for mmap and #179 for poll.

fbq
fbq reviewed Apr 12, 2021
View reviewed changes
rust/kernel/bindings_helper.h
@@ -10,6 +10,8 @@
#include <linux/version.h>
#include <linux/miscdevice.h>
#include <linux/poll.h>
#include <linux/mm.h>
#include <uapi/linux/android/binder.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, late to party. But I think in the long term, maybe we don't want to put this #include in the rust/kernel/bindings_helper.h? Maybe we can support module-level bindgen, that is allowing a module to have its own bindings_helper.h and only generate when necessary.

Maybe open an issue?

Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, we discussed this the other day. There are a couple of bits of functionality that will need to be expanded to individual modules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #181 for the documentation, #182 for the bindings.

ojeda pushed a commit that referenced this pull request Apr 21, 2025
@morimoto @broonie
ASoC: hdmi-codec: use RTD ID instead of DAI ID for ELD entry
d639e7f 
commit 0ecd24a ("ASoC: hdmi-codec: dump ELD through procfs") adds
"eld#%d" entry for sound proc. It is using DAI ID. But it is possible to
have duplicate DAI ID on same Sound Card. In such case, we will get below
error. To avoid duplicate entry name, use RTD ID instead of DAI ID.

	proc_dir_entry 'card0/eld#0' already registered
	WARNING: CPU: 3 PID: 74 at fs/proc/generic.c:377 proc_register+0x11c/0x1a4
	Modules linked in:
	CPU: 3 UID: 0 PID: 74 Comm: kworker/u33:5 Not tainted 6.14.0-rc1-next-20250206-arm64-renesas #174
	Hardware name: Renesas Salvator-X 2nd version board based on r8a77951 (DT)
	Workqueue: events_unbound deferred_probe_work_func
	pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
	pc : proc_register+0x11c/0x1a4
	ata1: SATA link down (SStatus 0 SControl 300)
	lr : proc_register+0x11c/0x1a4
	sp : ffff8000847db880
	x29: ffff8000847db880 x28: 0000000000000000 x27: ffff0004c3403c98
	x26: 0000000000000005 x25: ffff0004c14b03e4 x24: 0000000000000005
	x23: ffff0004c361adb8 x22: ffff800082f24860 x21: ffff0004c361ad00
	x20: ffff0004c14b0300 x19: ffff0004c14b02c0 x18: 00000000ffffffff
	x17: 0000000000000000 x16: 00400034b5503510 x15: ffff8001047db447
	x14: 0000000000000000 x13: 6465726574736967 x12: ffff800082e66d30
	x11: 000000000000028e x10: ffff800082e66d30 x9 : 00000000ffffefff
	x8 : ffff800082ebed30 x7 : 0000000000017fe8 x6 : 0000000000000000
	x5 : 80000000fffff000 x4 : 0000000000000000 x3 : 0000000000000000
	x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff0004c15b3600
	Call trace:
	 proc_register+0x11c/0x1a4 (P)
	 proc_create_data+0x3c/0x60
	 snd_info_register+0xd0/0x130
	 snd_info_register+0x30/0x130
	 snd_info_card_register+0x1c/0xbc
	 snd_card_register+0x194/0x1ec
	 snd_soc_bind_card+0x7f8/0xad0
	 snd_soc_register_card+0xe8/0xfc
	 devm_snd_soc_register_card+0x48/0x98
	 audio_graph_parse_of+0x1c4/0x1f8
	 graph_probe+0x6c/0x80
	...

Fixes: 0ecd24a ("ASoC: hdmi-codec: dump ELD through procfs")
Reported-by: Thuan Nguyen <[email protected]>
Signed-off-by: Kuninori Morimoto <[email protected]>
Tested-by: Thuan Nguyen <[email protected]>
Acked-by: Mark Brown <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex alex alex left review comments

@fbq fbq fbq left review comments

@ojeda ojeda ojeda approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wedsonaf @alex @fbq @ojeda